-
Notifications
You must be signed in to change notification settings - Fork 42
Rework kata, kata-cc images into release and debug images with different package compositions. #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fc188da to
31d168a
Compare
acd7a0e to
0f3c52f
Compare
|
Can you fix the commit message check? Probably easier to squash into 1 and paste your PR description into that. |
8c35600 to
fa81c2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR reworks the kata and kata-cc image composition to support separate release and debug images with distinct package sets.
- Removed the AGENT_POLICY_FILE configuration option from the README in the azure-linux builder documentation.
- Updated documentation to align with the new UVM image/component schema.
Reviewed Changes
| File | Description |
|---|---|
| tools/osbuilder/node-builder/azure-linux/README.md | Updated the confpods section by removing the AGENT_POLICY_FILE parameter to reflect the new image schema. |
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
tools/osbuilder/node-builder/azure-linux/README.md:173
- The removal of the AGENT_POLICY_FILE parameter should be clearly documented. Ensure that any related usage references or instructions are updated to reflect that this option is no longer available.
* `AGENT_POLICY_FILE`: Specify `allow-set-policy.rego` (default) to use
81d3c33 to
4cae2dc
Compare
Maybe good to factor the clean-rootfs change out in a separate commit |
Introduce clean-rootfs target in osbuilder Makefile to facilitate building multiple subsequent UVM files with different compostitions. To this end, also pipe a new UVM_BUILD_TYPE flag for IGVM build type. Signed-off-by: Cameron Baird <[email protected]>
sprt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly GTM. Let's also modifiy the Debug builds section of the readme so that those commands only build once (and not both release/debug).
fe95aba to
64995e8
Compare
64995e8 to
7c556eb
Compare
7c556eb to
1926579
Compare
Conditionally install kata-packages-uvm-debug metapackage Install image as kata-containers-debug.img if debug image is built; update debug config image field Make uvm_build/install build both release and debug images Signed-off-by: Cameron Baird <[email protected]>
1926579 to
fd01f01
Compare
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
Introduce logic to install the new schema of UVM images/components for kata containers and kata-cc, which are as follows:
kata-containers.img
kata-containers-debug.img
kata-containers-cc.img
kata-containers-cc-debug.img
Associated igvm, igvm-debug files for CC now map to the -cc and -cc-debug images respectively. This will allow for greater flexibility in composing these UVM images, allowing us to have different package compositions for production vs. debug pod sandboxes.
Test Methodology