agent: add back rego error logs #292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmihai1
reviewed
Jan 14, 2025
Redent0r
force-pushed
the
saulparedes/add_back_rego_error_logs
branch
from
68c4ca8 to
e0060a9
Compare
danmihai1
approved these changes
Jan 14, 2025
take_prints takes and clear prints per https://github.com/microsoft/regorus/blob/748c11cfa1319c808977194c1657e0fd866269be/src/engine.rs#L848 Add back error logs by not calling take_prints twice. Signed-off-by: Saul Paredes <[email protected]>
Redent0r
force-pushed
the
saulparedes/add_back_rego_error_logs
branch
from
e0060a9 to
c2f84a6
Compare
Redent0r
added
upstream/not-needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
The aim of this PR is to fix a regression introduced in https://github.com/microsoft/kata-containers/pull/273/files#diff-84f120758564e7adf93c69772f22eb04eaefcde3d30c01ddbe5a906f1611233d where rego error logs were no longer available after that change.
take_prints takes and clear prints per https://github.com/microsoft/regorus/blob/748c11cfa1319c808977194c1657e0fd866269be/src/engine.rs#L848
Add back error logs by not calling take_prints twice.
Test Methodology
tested locally: rego error logs are again printed as expected