Skip to content

Conversation

@manuelh-dev
Copy link

@manuelh-dev manuelh-dev commented Jul 17, 2024

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

Use container image sources from ACR/MCR.

Test Methodology
  • Internal test pipelines
  • validated that with mcr.microsoft.com/mirror/docker/library/ubuntu:jammy the policy hash changes if compiled without || layer.media_type.eq(manifest::IMAGE_LAYER_GZIP_MEDIA_TYPE)

Use container image sources from ACR/MCR.

Signed-off-by: Manuel Huber <[email protected]>
@manuelh-dev manuelh-dev added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Jul 17, 2024
@manuelh-dev manuelh-dev requested review from a team as code owners July 17, 2024 16:03
@manuelh-dev manuelh-dev merged commit 386cab0 into msft-main Jul 17, 2024
@manuelh-dev manuelh-dev deleted the tests/img-pull-src branch April 3, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream/not-needed PRs that will not be upstreamed (e.g. internal)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants