tardev: update tardev-snapshotter.service #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add to your commit description the reason why kubelet.service is better than containerd.service. |
miz060
force-pushed
the
mitchzhu/tardev-service
branch
from
a32f35f to
724b1ae
Compare
manuelh-dev
approved these changes
Jul 15, 2024
At the moment, we have circular dependencies between tardev-snapshotter.service and containerd.service. Specifically, containerd.service needs tardev-snapshotter.service to run any CC pods, while tardev-snapshotter.service needs containerd.service to download image layers. This dependency will be eliminated once we switch to using remote-snapshotter. Currently, tardev-snapshotter.service's binding to containerd.service gets delayed, and we won't be able to run any CC pods until the boot process is completed. It doesn't matter which service starts first. Based on the current logic, it makes more sense to use WantedBy=kubelet.service in tardev-snapshotter.service, as we won't be able to start any CC pods without kubelet. In the future, once tardev-snapshotter becomes a remote snapshotter again, it will make more sense to use WantedBy=containerd.service. Signed-off-by: Mitch Zhu <[email protected]>
miz060
force-pushed
the
mitchzhu/tardev-service
branch
from
724b1ae to
e6e6d34
Compare
danmihai1
approved these changes
Jul 16, 2024
sprt
pushed a commit
that referenced
this pull request
Feb 10, 2025
tardev: update tardev-snapshotter.service
sprt
pushed a commit
that referenced
this pull request
Feb 27, 2025
tardev: update tardev-snapshotter.service
sprt
pushed a commit
that referenced
this pull request
Mar 3, 2025
tardev: update tardev-snapshotter.service
sprt
pushed a commit
that referenced
this pull request
Mar 4, 2025
tardev: update tardev-snapshotter.service
sprt
pushed a commit
that referenced
this pull request
Mar 4, 2025
tardev: update tardev-snapshotter.service
sprt
pushed a commit
that referenced
this pull request
Mar 4, 2025
tardev: update tardev-snapshotter.service
sprt
pushed a commit
that referenced
this pull request
Mar 4, 2025
tardev: update tardev-snapshotter.service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
At the moment, we have circular dependencies between tardev-snapshotter.service and containerd.service. Specifically, containerd.service needs tardev-snapshotter.service to run any CC pods, while tardev-snapshotter.service needs containerd.service to download image layers. This dependency will be eliminated once we switch to using remote-snapshotter.
Currently, tardev-snapshotter.service's binding to containerd.service gets delayed, and we won't be able to run any CC pods until the boot process is completed. It doesn't matter which service starts first.
Based on the current logic, it makes more sense to use WantedBy=kubelet.service in tardev-snapshotter.service, as we won't be able to start any CC pods without kubelet. This is also what we have been using by having
sed -i -e 's/containerd.service/kubelet.service/g' tardev-snapshotter.servicein kata-containers-cc.spec.In the future, once tardev-snapshotter becomes a remote snapshotter again, it will make more sense to use WantedBy=containerd.service.