genpolicy: add persistent storage support for stateful sets #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arc9693
changed the title
|
LGTM. Run |
Redent0r
approved these changes
Jun 3, 2024
|
[like] Manuel Huber reacted to your message:
…________________________________
From: Saul Paredes ***@***.***>
Sent: Monday, June 3, 2024 4:48:53 PM
To: microsoft/kata-containers ***@***.***>
Cc: Manuel Huber ***@***.***>; Review requested ***@***.***>
Subject: Re: [microsoft/kata-containers] genpolicy: add persistent storage support for stateful sets (PR #199)
LGTM. Run python3 update_policy_samples.py to fix https://github.com/microsoft/kata-containers/actions/runs/9351824061/job/25738511724?pr=199 and follow https://dev.azure.com/mariner-org/mariner/_wiki/wikis/mariner.wiki/3368/Testing-genpolicy to trigger a test run
—
Reply to this email directly, view it on GitHub<#199 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOQ53BUPFV4XODXP2Z4R3KLZFSM7LAVCNFSM6AAAAABIWTOPPOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBVGY4DKNBQGM>.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
Author
|
Tests run after samples update: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=580957&view=results |
danmihai1
approved these changes
Jun 6, 2024
arc9693
force-pushed
the
archana1/add-pv-ss
branch
from
0a4e670 to
9d4fa0f
Compare
Author
|
Test run with latest updates: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=582238&view=results |
manuelh-dev
approved these changes
Jun 6, 2024
arc9693
added
the
upstream/not-needed
arc9693
force-pushed
the
archana1/add-pv-ss
branch
2 times, most recently
from
dc2af3d to
d388e34
Compare
This change adds support for volume claim templates for stateful sets. This is useful for stateful sets that require persistent storage, using cc-azurefile-csi, cc-azuredisk-csi or other storage providers. Signed-off-by: Archana Choudhary <[email protected]>
This patch updates the samples to include the support for persistant storage for statefulsets. Signed-off-by: Archana Choudhary <[email protected]>
arc9693
force-pushed
the
archana1/add-pv-ss
branch
from
d388e34 to
b41e55e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
upstream/missinglabel (orupstream/not-needed) has been set on the PR.Summary
This change adds support for volume claim templates for stateful sets. This is useful for stateful sets that require persistent storage, using cc-azurefile-csi, cc-azuredisk-csi or other storage providers.
Test Methodology