Skip to content

Conversation

@Redent0r
Copy link

@Redent0r Redent0r commented May 28, 2024

Update sev_snp param serialization to make it
match against cloud-hypervisor v38.0.72.

See cloud-hypervisor/cloud-hypervisor#5628 s#diff-c235a65d9dfdc1392f1c9546df912679bbdd74138316a04d9cfd53ef8fe1f907R 527

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • The upstream/missing label (or upstream/not-needed) has been set on the PR.
Summary

Update plataform config param from sev to sev_snp

This was done by updating cloud-hypervisor.yaml and running make generate-client-code && make go-fmt

Test Methodology

@Redent0r Redent0r force-pushed the saulparedes/update_sev_snp_param branch from 4855eca to dc45924 Compare May 28, 2024 23:22
Update the sev parameter to sev_snp in the cloud-hypervisor.yaml file to
match cloud-hypervisor 38.0.72.

See https://github.com/microsoft/cloud-hypervisor/blob/msft/v38.0.72/vmm
/src/config.rs#L687

Signed-off-by: Saul Paredes <[email protected]>
@Redent0r Redent0r force-pushed the saulparedes/update_sev_snp_param branch from dc45924 to 57ab374 Compare May 29, 2024 02:28
@Redent0r Redent0r added the upstream/not-needed PRs that will not be upstreamed (e.g. internal) label Jun 4, 2024
@Redent0r Redent0r marked this pull request as ready for review June 4, 2024 16:55
@Redent0r Redent0r requested review from a team as code owners June 4, 2024 16:55
@Redent0r Redent0r merged commit dde443c into msft-main Jun 5, 2024
@Redent0r Redent0r deleted the saulparedes/update_sev_snp_param branch June 5, 2024 19:20
@Redent0r Redent0r mentioned this pull request Jun 11, 2024
5 tasks
sprt pushed a commit that referenced this pull request Feb 10, 2025
virtcontainers: update sev_snp param serialization
sprt pushed a commit that referenced this pull request Feb 27, 2025
virtcontainers: update sev_snp param serialization
sprt pushed a commit that referenced this pull request Mar 3, 2025
virtcontainers: update sev_snp param serialization
sprt pushed a commit that referenced this pull request Mar 4, 2025
virtcontainers: update sev_snp param serialization
sprt pushed a commit that referenced this pull request Mar 4, 2025
virtcontainers: update sev_snp param serialization
sprt pushed a commit that referenced this pull request Mar 4, 2025
virtcontainers: update sev_snp param serialization
sprt pushed a commit that referenced this pull request Mar 4, 2025
virtcontainers: update sev_snp param serialization
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream/not-needed PRs that will not be upstreamed (e.g. internal)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants