Skip to content

Conversation

@sprt
Copy link

@sprt sprt commented May 7, 2024

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • genPolicy only: Updated sample YAMLs' policy annotations, if applicable
  • The upstream-missing label (or upstream-not-needed) has been set on the PR.
Summary

Upstream recently removed the requirement for commit messages to have the Fixes: #XXX line. Cherry-picking that change so that we can make the commit check required in our fork.

We've discussed this over and over. Let's try to get to an agreement here.
I will use this issue to remove the mandatory Issue - PR dependency.

Fixes: kata-containers#9500

Signed-off-by: Zvonko Kaiser <[email protected]>
@sprt sprt changed the title kata: Remove Issue - PR dependency ci: cherry-pick relaxed commit check May 7, 2024
@sprt sprt changed the title ci: cherry-pick relaxed commit check ci: cherry-pick relaxed commit check from upstream May 7, 2024
@sprt sprt added the upstream/merged PRs that have been merged upstream label May 7, 2024
@sprt sprt marked this pull request as ready for review May 7, 2024 17:50
@sprt sprt requested review from a team as code owners May 7, 2024 17:50
Copy link
Author

@sprt sprt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove these PR checklist items as well?

 ###### Merge Checklist  <!-- REQUIRED -->
 <!-- You can set them now ([x]) or set them later using the Github UI -->
 <!-- **All** boxes should be checked before merging the PR *(just tick any boxes which don't apply to this PR)* -->
-- [ ] Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
-  - [ ] Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
-- [ ] Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
 - [ ] genPolicy only: Ensured the tool still builds on Windows

@sprt sprt merged commit 9ce3226 into msft-main May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream/merged PRs that have been merged upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants