Skip to content

genpolicy: support read-only hostPath #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 15, 2024
Merged

genpolicy: support read-only hostPath #175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4b44220
genpolicy: support readonly hostpath
Redent0r Apr 14, 2024
a9e6fb8
genpolicy: update samples
Redent0r Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/agent/samples/policy/yaml/kubernetes/conformance/conformance-e2e.yaml
View file
Open in desktop

Large diffs are not rendered by default.

11 changes: 9 additions & 2 deletions src/tools/genpolicy/src/mount_and_storage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,13 @@ fn get_host_path_mount(
}
}

let access = match yaml_mount.readOnly {
Some(true) => {
debug!("setting read only access for host path mount");
"ro"
}
_ => "rw",
};
// TODO:
//
// - When volume.hostPath.path: /dev/ttyS0
Expand All @@ -208,15 +215,15 @@ fn get_host_path_mount(
if !path.starts_with("/dev/") && !path.starts_with("/sys/") {
debug!("get_host_path_mount: calling get_shared_bind_mount");
let propagation = if biderectional { "rshared" } else { "rprivate" };
get_shared_bind_mount(yaml_mount, p_mounts, propagation, "rw");
get_shared_bind_mount(yaml_mount, p_mounts, propagation, access);
} else {
let dest = yaml_mount.mountPath.clone();
let type_ = "bind".to_string();
let mount_option = if biderectional { "rshared" } else { "rprivate" };
let options = vec![
"rbind".to_string(),
mount_option.to_string(),
"rw".to_string(),
access.to_string(),
];

if let Some(policy_mount) = p_mounts.iter_mut().find(|m| m.destination.eq(&dest)) {
Expand Down
Loading