Skip to content

Conversation

@arc9693
Copy link

@arc9693 arc9693 commented Jan 30, 2024

Merge Checklist
  • Followed patch format from upstream recommendation: https://github.com/kata-containers/community/blob/main/CONTRIBUTING.md#patch-format
    • Included a single commit in a given PR - at least unless there are related commits and each makes sense as a change on its own.
  • Aware about the PR to be merged using "create a merge commit" rather than "squash and merge" (or similar)
  • genPolicy only: Ensured the tool still builds on Windows
  • genPolicy only: Updated sample YAMLs' policy annotations, if applicable
  • The upstream-missing label (or upstream-not-needed) has been set on the PR.
Summary

Modified yaml.rs to prevent panic when genpolicy is called for a PodDisruptionBudget spec.

Associated issues

https://microsoft.visualstudio.com/OS/_workitems/edit/48139280/

Links to CVEs
Test Methodology

Pipeline e2e tests: https://dev.azure.com/mariner-org/mariner/_build/results?buildId=493910&view=results
Local test:
Spec:
image
Before:
image
After:
image

Prevent panic for PDB specs

Signed-off-by: Archana Choudhary <[email protected]>
@arc9693 arc9693 added the upstream/missing PRs that are yet to be upstreamed label Jan 30, 2024
@arc9693 arc9693 marked this pull request as ready for review January 30, 2024 13:45
@arc9693 arc9693 requested review from a team as code owners January 30, 2024 13:45
@arc9693 arc9693 changed the title Add support for PodDisruptionBudget spec genpolicy: add support for PodDisruptionBudget spec Jan 30, 2024
@arc9693 arc9693 merged commit 17da19f into msft-main Jan 30, 2024
@Redent0r Redent0r added upstream/merged PRs that have been merged upstream and removed upstream/missing PRs that are yet to be upstreamed labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

upstream/merged PRs that have been merged upstream

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants