-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: for filepaths/folders templates, the icon type of the suggestion… #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test that covers this case, something like ls sr
and just take the first item so we know it has a folder icon and then do something like ls READ
to capture that it has the file icon?
Trying to have all PRs adding tests for the behavior they fix moving forward
111b2df
to
d7aabfc
Compare
Thank you very much for the suggestion, I've added the corresponding test case. I verified that it was already OK. But I found a problem with the other test cases. Do you want to fix it immediately or skip it first? |
If it continues to be an issue, feel free to skip it. I'll address it later |
@alanhg Looks like you'll need to update the e2e tests too since they also run into those icon issues |
@cpendery Also, I found a lot of failures in e2e tests. |
The test |
…n needs to be specified to avoid going to the default icon.
2632c0e
to
49383c0
Compare
I have updated the test, thank you. ![]() |
For filepaths / folder templates, the icon type of the suggestion needs to be specified to avoid going to the default icon.
thanks for the review.
@cpendery