build: add husky,support lint code when pre-commmit #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpendery
reviewed
Mar 4, 2024
| }, | ||
| "lint-staged": { | ||
| "{,src/**/}*.{ts,tsx}": [ | ||
| "eslint --fix", |
There was a problem hiding this comment.
Can we re-use the npm run lint:fix command here to keep everything consistent between hooks & package.json commands?
There was a problem hiding this comment.
yes.
Because I was thinking of doing a git commit to perform a lint on the modified files, if you call our lint:fix it actually performs a lint on all the files. it depends on what you're used to, but if you want it to be that way, I'll change it again.
There was a problem hiding this comment.
Let's just stick with this version so it's only running on staged files
cpendery
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the commit code automatically lint to avoid style issues.
@cpendery thanks.