Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reset the selected completion index to 0 to prevent the selected… #173

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

alanhe421
Copy link
Contributor

@alanhe421 alanhe421 commented Feb 22, 2024

I found that the default selected index for completion needs to be reset to avoid the default selected index still being the previously selected one when the completion is displayed.

Please help to review this. @cpendery

… state from not being correctly initialized when the completion toggle.
@cpendery
Copy link
Member

cpendery commented Mar 1, 2024

@alanhg, thanks for the fix! If you could fix the formatting by running the lint:fix command before committing that would be awesome. Pushing the lint fixes to your PR now

Signed-off-by: Chapman Pendery <[email protected]>
Copy link
Member

@cpendery cpendery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpendery cpendery merged commit ddd79c5 into microsoft:main Mar 1, 2024
3 checks passed
@alanhe421
Copy link
Contributor Author

@cpendery

I am using WebStorm, and it seems that the eslint configuration that was not applied to successfully walk the project.

Here in order to avoid such problems, I will submit another husky to ensure that the submit automatically executes lint to avoid such things.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants