Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support new version autocomplete #153

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

alanhe421
Copy link
Contributor

I submitted this PR, but there are a few points that I'm uncertain about and need to discuss:

  1. Do we need to lock the version of @withfig/autocomplete or revert it back to the previous ^? We previously locked the version because the new updates from fig caused user startup errors. I locked the version as a temporary solution. Since I have now fixed the error caused by the loading standards, I upgraded the package version. If we decide to revert to ^, I will need to make another change. The advantage of locking the version is that we don't have to worry about fig updates causing unexpected errors in our implementation, but the downside is that we need to continually update it.
image
  1. The reason for the error when installing new versions of @withfig/autocomplete, such as v2.651.0, is that it provided specifications with certain information that led to errors. Firstly, I think this is unreasonable, and I understand it to be an issue with the Fig autocomplete package. However, for the inshellisense project, I believe we can improve robustness to prevent the unreasonableness of a single specification from causing errors in the overall load.
image image

@alanhe421
Copy link
Contributor Author

@cpendery
Hi, Can you review this modification?

@cpendery
Copy link
Member

@alanhg there are definitely more improvements to make on the runtime. These changes aren't breaking for fig's runtime, so hopefully we can get to a point of equivalent implementation. I'll be working on adding a much more robust test suite as we push towards 0.0.1

Signed-off-by: Chapman Pendery <[email protected]>
Copy link
Member

@cpendery cpendery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpendery cpendery merged commit ffae75f into microsoft:main Feb 14, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants