fix: support new version autocomplete #153
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submitted this PR, but there are a few points that I'm uncertain about and need to discuss:
@withfig/autocomplete
or revert it back to the previous ^? We previously locked the version because the new updates from fig caused user startup errors. I locked the version as a temporary solution. Since I have now fixed the error caused by the loading standards, I upgraded the package version. If we decide to revert to ^, I will need to make another change. The advantage of locking the version is that we don't have to worry about fig updates causing unexpected errors in our implementation, but the downside is that we need to continually update it.@withfig/autocomplete
, such as v2.651.0, is that it provided specifications with certain information that led to errors. Firstly, I think this is unreasonable, and I understand it to be an issue with the Fig autocomplete package. However, for the inshellisense project, I believe we can improve robustness to prevent the unreasonableness of a single specification from causing errors in the overall load.