Fix BinSkim issues #258
Merged
Fix BinSkim issues #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last PR #256 factored out the Windows specific build overrides into the
HermesWindows.cmake.While the idea to re-enable SDL required warnings worked for the compiler, it did not work for the BinSkim that does a simple scan of strings passed to compilers. As a result our CI build failed and we could not produce a new package.
In this PR we put back the SDL-related changes to the
Hermes.cmakeand comment out the SDL-required disabled warnings.The PR also brings some README.md changes from the
microsoft/node-api-jsirepo.