[Work in Progress] SqlException State 35 #619
Conversation
…throws a SqlException with State 35 to take care of the following exception: "A connection was successfully established with the server, but then an error occurred during the login process. (provider: TCP Provider, error: 35 - An internal exception was caught)"
| /// Retries have been added to cater to the following exception: | ||
| /// "A connection was successfully established with the server, but then an error occurred during the login process. | ||
| /// (provider: TCP Provider, error: 35 - An internal exception was caught)" | ||
| /// </remarks> |
There was a problem hiding this comment.
Do we want to add a test to exercise this logic specifically?
This would retry on any internal exception - is this the only one that exists or is there potentially others with state 35?
Are there exceptions aside from those with state 35 that should be retried?
| { | ||
| int attempts = 1; | ||
|
|
||
| await Policy.Handle<SqlException>(se => se.State == 35) |
There was a problem hiding this comment.
nit: no need to await this. Simply return the Task
| int attempts = 1; | ||
|
|
||
| await Policy.Handle<SqlException>(se => se.State == 35) | ||
| .WaitAndRetryAsync( |
There was a problem hiding this comment.
nit: indent by 1 here and below
| _logger.LogWarning( | ||
| exception, | ||
| "Attempt {Attempt} of {MaxAttempts} to open Sql connection.", | ||
| attempts++, |
There was a problem hiding this comment.
Doesn't the retryCount parameter provide this?
| /// <remarks> | ||
| /// Retries have been added to cater to the following exception: | ||
| /// "A connection was successfully established with the server, but then an error occurred during the login process. | ||
| /// (provider: TCP Provider, error: 35 - An internal exception was caught)" |
There was a problem hiding this comment.
Are we sure this is something we want to retry? The SQL Client library already retries a number of different errors? Do we know why this isn't retried? Is this a "retryable" exception? For example, I see an old issue in the issues page for this problem when moving from .NET 5 -> 6: dotnet/SqlClient#1402. Unsure if it's related, but I am reluctant to add new retries if we aren't quite sure why they're happening.
|
Closing as this will be taken care of by Daniel's work: https://microsofthealth.visualstudio.com/Health/_workitems/edit/96670. |
Description
Added retry logic on Sql connection OpenAsync method when the method throws a SqlException with State 35 to take care of the following exception:
"A connection was successfully established with the server, but then an error occurred during the login process. (provider: TCP Provider, error: 35 - An internal exception was caught)"
Related issues
AB#96340
Semver Change
Skip