Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unlock google.golang.org/grpc #1177

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TBBle
Copy link
Contributor

@TBBle TBBle commented Sep 26, 2021

This was originally locked in #1000 based on containerd's resolution for containerd/ttrpc#62. However, the lock on google.golang.org/grpc was dropped in containerd/containerd#5613 while upgrading libraries we don't actually use, so it was probably never applicable for us, while the lock on google.golang.org/genproto was kept.

See also containerd/ttrpc#89, which intended to document that only google.golang.org/genproto needs to be locked. However, this PR was dropped in favour of containerd/ttrpc#92, dropping gogo/protobuf entirely (somehow).

Draft because:

  • Needs to be updated to align with the approach in containerd instead, see Unlock google.golang.org/grpc #1177 (comment)
  • This was an "in-passing" inspiration, and I haven't tested it in any way except the CI test run. I suspect someone with more expertise is already taking care of this in concert with the containerd changes.

@TBBle TBBle force-pushed the unlock-grpc-version branch from 0e15f1f to aeabdd3 Compare November 27, 2021 09:32
@TBBle
Copy link
Contributor Author

TBBle commented Nov 27, 2021

Note to self: Protobuf implementation regeneration command is in #1175, e.g., 02cfac9.

@TBBle
Copy link
Contributor Author

TBBle commented Feb 22, 2022

For future work, #1302 has pointed out that containerd/ttrpc#92 has an overarching issue at containerd/containerd#6564 which might be clearer about how to migrate away from github.com/gogo/protobuf.

@TBBle TBBle force-pushed the unlock-grpc-version branch from aeabdd3 to 56c3f26 Compare May 4, 2022 10:42
This was originally locked in microsoft#1000 based on containerd's resolution for
containerd/ttrpc#62. However, this was dropped
in containerd/containerd#5613 while upgrading
libraries we don't actually use, so it was probably never applicable for
us.

See also containerd/ttrpc#89, which documents
that only google.golang.org/genproto needs to be locked.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
@TBBle TBBle force-pushed the unlock-grpc-version branch from 56c3f26 to a5d497a Compare May 4, 2022 10:49
@TBBle
Copy link
Contributor Author

TBBle commented May 4, 2022

Rebased onto master, incorporating #1302 so protobuf regeneration is now documented and verified in GitHub Actions.

containerd/containerd#6564 has been closed by merge of containerd/containerd#6841 (and also containerd/containerd#6867 is a relevant follow-up) which still carries the replaces for genproto, but containerd/containerd#5208 (comment) notes that these may be able to be removed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant