Skip to content

chore: upgrade Nx to 13.10.6 #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
layershifter merged 1 commit into from
Jan 9, 2023
Merged

chore: upgrade Nx to 13.10.6 #310

layershifter merged 1 commit into from
Jan 9, 2023

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Jan 9, 2023 •
edited
Loading

This PR bumps:

  • nx to 13.10.6 to solve some security alerts; we are also down to two patches on Nx packages 🎉
  • typescript to 4.7.4 to support syntax used in latest @linaria/tags (chore: upgrade to Linaria v4 #309)

@github-actions
Copy link

github-actions bot commented Jan 9, 2023 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
core
makeResetStyles (runtime)		 17.05 kB
6.321 kB		 17.028 kB
6.321 kB		 -22 B
core
makeStyles + mergeClasses (runtime)		 21.158 kB
7.89 kB		 21.136 kB
7.888 kB		 -22 B
-2 B
react
__styles + mergeClasses (build time)		 4.004 kB
1.785 kB		 3.942 kB
1.784 kB		 -62 B
-1 B
react
makeResetStyles (runtime)		 18.887 kB
7.06 kB		 18.803 kB
7.054 kB		 -84 B
-6 B
react
makeStaticStyles (runtime)		 9.732 kB
4.158 kB		 9.654 kB
4.135 kB		 -78 B
-23 B
react
makeStyles + mergeClasses (runtime)		 23.003 kB
8.596 kB		 22.919 kB
8.591 kB		 -84 B
-5 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
core
makeStyles + mergeClasses (build time)		 2.19 kB
1.045 kB
react
__css + mergeClasses (build time)		 2.227 kB
1.046 kB
🤖 This report was generated against 16250ce781f4f8329270ad83fdead9922bdfc234

@layershifter layershifter force-pushed the chore/bump-nx-13 branch 2 times, most recently from d8b3012 to 2559272 Compare January 9, 2023 16:14
@layershifter layershifter marked this pull request as ready for review January 9, 2023 16:36
@layershifter layershifter requested a review from a team as a code owner January 9, 2023 16:36
ling1726
ling1726 reviewed Jan 9, 2023
View reviewed changes
apps/benchmark/src/implementations/inline-styles/Provider.tsx
import React from 'react';

const InlineStylesProvider: React.FC = ({ children }) => {
const InlineStylesProvider: React.FC<{ children: React.ReactNode }> = ({ children }) => {
Copy link
Contributor

@ling1726 ling1726 Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this relevant to the NX upgrade ? seems more like React 18 typings changed

Copy link
Contributor

@ling1726 ling1726 Jan 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see you bumped react types to 18 too

@layershifter layershifter merged commit ed7bf7f into microsoft:main Jan 9, 2023
@layershifter layershifter deleted the chore/bump-nx-13 branch January 9, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ling1726 ling1726 ling1726 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@layershifter @ling1726