Skip to content

[Compatibility] Added CLIENT GETNAME, SETNAME, SETINFO commands #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 7, 2024
Merged

[Compatibility] Added CLIENT GETNAME, SETNAME, SETINFO commands #851

merged 7 commits into from
Dec 7, 2024
+395 −9

Conversation

Vijay-Nirmal
Copy link
Contributor

Adding the CLIENT GETNAME, SETNAME, SETINFO commands to garnet

  • Add CLIENT GETNAME, SETNAME, SETINFO commands
  • Add Integration Test cases, ACL Test
  • Add documentation

@TalZaccai TalZaccai requested a review from vazois December 5, 2024 19:25
vazois
vazois approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@vazois vazois left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Please resolve any conflicts

@vazois
Copy link
Collaborator

vazois commented Dec 6, 2024

@Vijay-Nirmal please resolve the conflicts because we cannot merge it as is

@Vijay-Nirmal
Copy link
Contributor Author

@vazois Done

@vazois vazois merged commit ebb9071 into microsoft:main Dec 7, 2024
15 checks passed
@yuseok-kim-edushare
Copy link
Contributor

Wow! Awesome!
Thank you for your works, this working improve compatibility,
ex in java) Spring data redis , lettuce

@Vijay-Nirmal Vijay-Nirmal deleted the new/GETNAME-SETNAME-SETINFO-command branch December 7, 2024 07:47
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vazois vazois vazois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vijay-Nirmal @vazois @yuseok-kim-edushare