Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Link defaults.conf from Configuration article #846

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

mloskot
Copy link
Contributor

@mloskot mloskot commented Dec 2, 2024

Let's utilise the awesome feature of hyperlinking, especially, that the Configurable Settings table does not offer displaying of the default values.

Let's utilise the awesome feature of hyperlinking, especially, that the [Configurable Settings](https://github.com/microsoft/garnet/blob/55f94e3ea19c9204ed9154db40bf93dfa8d4f7ce/website/docs/getting-started/configuration.md?plain=1#L68) table does not offer displaying of the default values.
@TalZaccai
Copy link
Contributor

Let's utilise the awesome feature of hyperlinking, especially, that the Configurable Settings table does not offer displaying of the default values.

This link would need to work from our github.io website, so we should probably opt for a full URL rather than a relative path.

Tradeoff is the file is linked from `main` branch, so there is 
potential of divergence between the file and the docs from
latest release.
@mloskot
Copy link
Contributor Author

mloskot commented Dec 3, 2024

@TalZaccai

we should probably opt for a full URL rather than a relative path.

Good point. Done.

@TalZaccai TalZaccai self-requested a review December 3, 2024 19:27
@badrishc badrishc merged commit c04d862 into microsoft:main Dec 4, 2024
7 checks passed
@mloskot mloskot deleted the patch-1 branch December 4, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants