Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Added BLMPOP command #842

Merged
merged 8 commits into from
Dec 10, 2024

Conversation

Vijay-Nirmal
Copy link
Contributor

@Vijay-Nirmal Vijay-Nirmal commented Nov 30, 2024

Adding the BLMPOP commands to garnet

  • Add BLMPOP commands
  • Add Integration Test cases, ACL Test and Slot Verification Test (There is no Blocking command in cluster slot verification test as of now)
  • Add documentation

@Vijay-Nirmal Vijay-Nirmal changed the title Added BLMPOP command [Compatibility] Added BLMPOP command Nov 30, 2024
@TalZaccai TalZaccai self-requested a review December 3, 2024 19:26
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Please see comments.

Copy link
Contributor

@vazois vazois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@vazois vazois self-requested a review December 9, 2024 17:06
@vazois vazois dismissed TalZaccai’s stale review December 10, 2024 19:54

The comments from the PR author were addressed.

@vazois vazois merged commit cf2f89e into microsoft:main Dec 10, 2024
15 checks passed
@Vijay-Nirmal Vijay-Nirmal deleted the new/BLMPOP-command branch December 11, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants