Skip to content

[Compatibility] Added ZUNION, ZUNIONSTORE commands #833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Dec 18, 2024
Merged

[Compatibility] Added ZUNION, ZUNIONSTORE commands #833

merged 15 commits into from
Dec 18, 2024

Conversation

Vijay-Nirmal
Copy link
Contributor

Adding the ZUNION, ZUNIONSTORE commands to garnet

  • Add ZUNION, ZUNIONSTORE commands
  • Add Integration Test cases, ACL Test and Slot Verification Test
  • Add documentation

@TalZaccai TalZaccai self-requested a review December 3, 2024 19:17
TalZaccai
TalZaccai requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Most comments are similar to those on the ZINTER PR.

@Vijay-Nirmal
Copy link
Contributor Author

@TalZaccai Fixed review commands

TalZaccai
TalZaccai reviewed Dec 12, 2024
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the comments! Couple final nits & one small comment still open from previous review

@Vijay-Nirmal
Copy link
Contributor Author

Tested all review comments. @TalZaccai I couldn't find any "comment still open from previous review"

TalZaccai
TalZaccai reviewed Dec 16, 2024
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflicts and I’ll merge this in @Vijay-Nirmal :)

@Vijay-Nirmal
Copy link
Contributor Author

Fixed conflicts

@TalZaccai TalZaccai merged commit d965f8a into microsoft:main Dec 18, 2024
15 checks passed
@Vijay-Nirmal Vijay-Nirmal deleted the new/ZUNION-ZUNIONSTORE-commands branch December 18, 2024 04:55
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TalZaccai TalZaccai Awaiting requested review from TalZaccai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Vijay-Nirmal @TalZaccai