Server side transaction failure in Cluster Mode #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion. It's not set and results in object reference null exception for cluster mode transactions
badrishc
approved these changes
Oct 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
We created a custom server side transaction and tested the behavior. The commands ran perfectly fine for the transaction.
However, when deployed to our k8s cluster, we saw that the transactions failed with error:
(error) ERR Transaction failed.We then tried reproducing the error locally when running Garnet in cluster mode and were able to reproduce the issue.
The error occurred the Prepare stage of the transaction when we tried to obtain a lock on the key.
CustomTransactionProcedure > AddKey > txnManager.VerifyKeyOwnership > clusterSessionis null.The PR attempts to give a try at fixing it.
ClusterSession is null in TransactionManager as it's initialized after TransactionManager and not assigned later.