Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Compatibility] Added NOVALUE option for HSCAN #701

Merged
merged 9 commits into from
Oct 13, 2024

Conversation

Vijay-Nirmal
Copy link
Contributor

@Vijay-Nirmal Vijay-Nirmal commented Oct 3, 2024

  • Add NOVALUE option for HSCAN
  • Updated Test cases
  • Updated documentation
  • Updated StackExchange.Redis to 2.8.16 to get the new HashScanNoValues method in the test project

@TalZaccai TalZaccai requested a review from yrajas October 3, 2024 18:18
Copy link
Contributor

@yrajas yrajas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Count to be adjusted for hscan.

libs/server/Objects/Hash/HashObject.cs Show resolved Hide resolved
@Vijay-Nirmal
Copy link
Contributor Author

Vijay-Nirmal commented Oct 9, 2024

@yrajas Fixed the review command and added one more case to test this case

Edit: Fixing the pipeline faliure

@Vijay-Nirmal
Copy link
Contributor Author

@yrajas Fixed failed test case

@Vijay-Nirmal Vijay-Nirmal requested a review from yrajas October 12, 2024 06:38
@yrajas yrajas merged commit 7e29c3a into microsoft:main Oct 13, 2024
15 checks passed
@Vijay-Nirmal Vijay-Nirmal deleted the new/novalue-option-for-hscan branch October 13, 2024 18:17
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants