Updated "Load a model" Step For Python Setup - #806
Merged
Conversation
|
Mason Corey (@themason2011) is attempting to deploy a commit to the MSFT-AIP Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR adds a Python import statement to the install command snippet, ensuring users see the necessary from foundry_local_sdk import Configuration, FoundryLocalManager line before the usage code.
Changes:
- Added the
from foundry_local_sdk import ...import line to the Python setup snippet in the install command component.
Nenad Banfic (nenad1002)
previously approved these changes
Jun 16, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Maanav Dalal (MaanavD)
enabled auto-merge (squash)
June 18, 2026 20:43
Maanav Dalal (MaanavD)
disabled auto-merge
June 18, 2026 20:44
Maanav Dalal (MaanavD)
enabled auto-merge (squash)
June 18, 2026 20:44
Maanav Dalal (MaanavD)
approved these changes
Jun 18, 2026
bmehta001
added a commit
that referenced
this pull request
Jun 30, 2026
#824) ## Summary Collapses the separate **WinML** and **non-WinML** SDK flavors into a **single package per SDK** (C#, Python, JS). Consumers no longer pick between a `.WinML` SKU and a base SKU: on Windows the reg-free **WinML 2.x EP catalog** is always available, and other platforms are unaffected. ## What changed - **native** — always enable the WinML EP catalog on Windows; drop the build-flavor split. - **C#** — single `Microsoft.AI.Foundry.Local` package; drop the `.WinML` SKU and the `UseWinML` switch. - **Python** — single wheel; drop the WinML variant. - **JS** — bundle the WinML 2.x runtime in the npm package on Windows. - **macOS** — simplify ORT dylib staging to mirror Linux. - **CI (`.pipelines/v2`)** — collapse the WinML/non-WinML matrix into one build per SDK. - **samples (C#)** — use the unified package; central package management via `Directory.Packages.props`. - **docs / www** — describe the unified package; one install command per SDK in the download dropdown. - **JS exit fix** — clean process exit after loading a native Manager (`beforeExit`/`exit` handlers), avoiding the ORT-teardown crash on graceful Node exit. ## Notes / follow-ups - Rebased onto `main` (picks up #813 `sdk_legacy` removal, #821 vision samples, #810 npm bump, #806). - The #821 vision samples (C#/JS/Rust) landed after this branch and are **not yet** migrated to the unified package / central package management — follow-up needed. - **Draft**: pending CI (multi-SDK pack + build) verification. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old setup code for Python did not include importing necessary packages when loading a model. I added the line required to import the packages and run the python snippet.