Skip to content

Conversation

@suryasu
Copy link
Contributor

@suryasu suryasu commented Jul 24, 2019

Pull request checklist

Description of changes

Adds aria label to custom picker on the demo page. This is not an issue with the custom picker component since the label should be defined by whoever creates the custom picker so that it's specific enough for screen readers

Microsoft Reviewers: Open in CodeFlow

@size-auditor
Copy link

size-auditor bot commented Jul 24, 2019

Size Auditor did not detect a change in bundle size for any component!

@msft-github-bot
Copy link
Contributor

Component Perf Analysis:

Scenario Master Samples * PR Samples *
BaseButton 701 681
BaseButton (experiments) 1559 1552
DefaultButton 932 933
DefaultButton (experiments) 1751 1772
DetailsRow 3995 4071
DetailsRow without styles 3996 4228
DocumentCardTitle with truncation 30599 30134
MenuButton 1769 1705
MenuButton (experiments) 4136 4171
PrimaryButton 1187 1127
PrimaryButton (experiments) 2046 2109
SplitButton 3291 3318
SplitButton (experiments) 7777 7791
Stack 442 440
Stack with Intrinsic children 1079 1070
Stack with Text children 4143 4075
Text 359 353
Toggle 814 832
Toggle (experiments) 2176 2172
button 64 58
* Sample counts can vary by up to 30% and shouldn't be used solely for determining regression. For more information please see the Perf Testing wiki.

@micahgodbolt
Copy link
Member

Thanks for the PR! @joschect is the codeowner of this control. I'll wait for his sign off as he knows the control the best.

@joschect joschect merged commit 6e800c0 into microsoft:master Jul 25, 2019
@msft-github-bot
Copy link
Contributor

🎉[email protected] has been released which incorporates this pull request.:tada:

Handy links:

@msft-github-bot msft-github-bot mentioned this pull request Aug 3, 2019
7 tasks
@microsoft microsoft locked as resolved and limited conversation to collaborators Sep 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pickers A11y Pass

4 participants