Skip to content

Tooltip: Fixing 'persist on scroll' issues #9749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
micahgodbolt merged 3 commits into from
Jul 10, 2019
Merged

Tooltip: Fixing 'persist on scroll' issues #9749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eca43a0
Tooltip: Fixing 'persist on scroll' issues.
khmakoto Jul 9, 2019
4f3a3b2
Change files
khmakoto Jul 9, 2019
60f2b26
Allowing scroll on document when hovering over Tooltip.
khmakoto Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/office-ui-fabric-react-2019-07-09-16-44-29-tooltipHover.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"comment": "Tooltip: Fixing 'persist on scroll' issues.",
"type": "patch",
"packageName": "office-ui-fabric-react",
"email": "humbertomakotomorimoto@gmail.com",
"commit": "eca43a063b66456426959e89bc1c32df7de9fc67",
"date": "2019-07-09T23:44:29.420Z"
}
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/Callout/CalloutContent.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,8 +332,8 @@ export class CalloutContentBase extends React.Component<ICalloutProps, ICalloutS
this._disposables.push(
on(this._targetWindow, 'scroll', this._dismissOnScroll, true),
on(this._targetWindow, 'resize', this._dismissOnResize, true),
on(this._targetWindow.document.documentElement as any, 'focus', this._dismissOnLostFocus, true), // FABRIC7TODO remove any
on(this._targetWindow.document.documentElement as any, 'click', this._dismissOnLostFocus, true) // FABRIC7TODO remove any
on(this._targetWindow.document.documentElement, 'focus', this._dismissOnLostFocus, true),
on(this._targetWindow.document.documentElement, 'click', this._dismissOnLostFocus, true)
);
this._hasListeners = true;
}, 0);
Expand Down
2 changes: 2 additions & 0 deletions packages/office-ui-fabric-react/src/components/Tooltip/TooltipHost.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,13 @@ export class TooltipHostBase extends BaseComponent<ITooltipHostProps, ITooltipHo
directionalHint={directionalHint}
directionalHintForRTL={directionalHintForRTL}
calloutProps={assign({}, calloutProps, {
onDismiss: this._hideTooltip,
onMouseEnter: this._onTooltipMouseEnter,
onMouseLeave: this._onTooltipMouseLeave
})}
onMouseEnter={this._onTooltipMouseEnter}
onMouseLeave={this._onTooltipMouseLeave}
onWheel={this._hideTooltip}
{...getNativeProps(this.props, divProperties)}
{...tooltipProps}
/>
Expand Down