Skip to content

<Fabric> element does not affect global button styling. #9076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdhuntington merged 1 commit into from
May 20, 2019
Merged

<Fabric> element does not affect global button styling. #9076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@uifabric/experiments/fix-button-global-styling_2019-05-15-18-24.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/experiments",
"comment": "<Fabric> element does not affect global button styling.",
"type": "minor"

@khmakoto khmakoto May 16, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be of type patch since this is not changing the API surface?

@jdhuntington jdhuntington May 17, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think minor is appropriate as it will affect global styles for anyone that uses the <Fabric> element.

}
],
"packageName": "@uifabric/experiments",
"email": "jdh@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/fix-button-global-styling_2019-05-13-18-25.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "<Fabric> element does not affect global button styling.",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "jdh@microsoft.com"
}
8 changes: 8 additions & 0 deletions packages/experiments/src/components/MicroFeedback/__snapshots__/MicroFeedback.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@ exports[`MicroFeedback renders correctly with no props 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -164,6 +168,10 @@ exports[`MicroFeedback renders correctly with no props 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down
56 changes: 56 additions & 0 deletions packages/experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -155,6 +159,10 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -277,6 +285,10 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-height: 32px;
min-width: 32px;
outline: transparent;
Expand Down Expand Up @@ -383,6 +395,10 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-height: 32px;
min-width: 32px;
outline: transparent;
Expand Down Expand Up @@ -489,6 +505,10 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-height: 32px;
min-width: 32px;
outline: transparent;
Expand Down Expand Up @@ -595,6 +615,10 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-height: 32px;
min-width: 32px;
outline: transparent;
Expand Down Expand Up @@ -701,6 +725,10 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-height: 32px;
min-width: 32px;
outline: transparent;
Expand Down Expand Up @@ -805,6 +833,10 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -934,6 +966,10 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1075,6 +1111,10 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1197,6 +1237,10 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1471,6 +1515,10 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
font-weight: 400;
height: 32px;
line-height: 30px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1604,6 +1652,10 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -1721,6 +1773,10 @@ exports[`Pagination render comboBox Pagination correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down
16 changes: 16 additions & 0 deletions ...s/office-ui-fabric-react/src/components/Breadcrumb/__snapshots__/Breadcrumb.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,6 +460,10 @@ exports[`Breadcrumb basic rendering renders breadcumb correctly 2 1`] = `
font-size: 16px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
overflow: hidden;
padding-bottom: 0;
Expand Down Expand Up @@ -1210,6 +1214,10 @@ exports[`Breadcrumb basic rendering renders breadcumb correctly 4 1`] = `
font-size: 16px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
overflow: hidden;
padding-bottom: 0;
Expand Down Expand Up @@ -1591,6 +1599,10 @@ exports[`Breadcrumb basic rendering renders breadcumb correctly 5 1`] = `
font-size: 16px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
overflow: hidden;
padding-bottom: 0;
Expand Down Expand Up @@ -1810,6 +1822,10 @@ exports[`Breadcrumb basic rendering renders breadcumb correctly 6 1`] = `
font-size: 16px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
overflow: hidden;
padding-bottom: 0;
Expand Down
2 changes: 1 addition & 1 deletion packages/office-ui-fabric-react/src/components/Button/BaseButton.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const getStyles = memoizeFunction(
verticalAlign: 'top',
padding: '0 16px',
borderRadius: 0,

margin: 0,
selectors: {
// IE11 workaround for preventing shift of child elements of a button when active.
':active > *': {
Expand Down
5 changes: 4 additions & 1 deletion packages/office-ui-fabric-react/src/components/Button/SplitButton/SplitButton.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,10 @@ export const getStyles = memoizeFunction(
cursor: 'pointer',
verticalAlign: 'top',
width: 32,
marginLeft: -1
marginLeft: -1,
marginTop: 0,
marginRight: 0,
marginBottom: 0
},

splitButtonDivider: {
Expand Down
4 changes: 4 additions & 0 deletions ...ffice-ui-fabric-react/src/components/Button/__snapshots__/Button.deprecated.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ exports[`Button renders CompoundButton correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: auto;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
max-width: 280px;
min-height: 72px;
outline: transparent;
Expand Down
24 changes: 24 additions & 0 deletions packages/office-ui-fabric-react/src/components/Button/__snapshots__/Button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ exports[`Button renders ActionButton correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 40px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -141,6 +145,10 @@ exports[`Button renders CommandBarButton correctly 1`] = `
font-family: 'Segoe UI', 'Segoe UI Web (West European)', 'Segoe UI', -apple-system, BlinkMacSystemFont, 'Roboto', 'Helvetica Neue', sans-serif;
font-size: 14px;
font-weight: 400;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-width: 40px;
outline: transparent;
padding-bottom: 0;
Expand Down Expand Up @@ -318,6 +326,10 @@ exports[`Button renders CompoundButton correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: auto;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
max-width: 280px;
min-height: 72px;
outline: transparent;
Expand Down Expand Up @@ -465,6 +477,10 @@ exports[`Button renders DefaultButton correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-width: 80px;
outline: transparent;
padding-bottom: 0;
Expand Down Expand Up @@ -583,6 +599,10 @@ exports[`Button renders IconButton correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -704,6 +724,10 @@ exports[`Button renders a DefaultButton with a keytip correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 32px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-width: 80px;
outline: transparent;
padding-bottom: 0;
Expand Down
4 changes: 4 additions & 0 deletions ...e-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.deprecated.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ exports[`ComboBox Renders ComboBox correctly 1`] = `
font-weight: 400;
height: 32px;
line-height: 30px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down
8 changes: 8 additions & 0 deletions packages/office-ui-fabric-react/src/components/ComboBox/__snapshots__/ComboBox.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,10 @@ exports[`ComboBox Renders correctly 1`] = `
font-weight: 400;
height: 32px;
line-height: 30px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down Expand Up @@ -455,6 +459,10 @@ exports[`ComboBox renders with a Keytip correctly 1`] = `
font-weight: 400;
height: 32px;
line-height: 30px;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
outline: transparent;
padding-bottom: 0;
padding-left: 4px;
Expand Down
8 changes: 8 additions & 0 deletions ...-fabric-react/src/components/CommandBar/__snapshots__/CommandBar.deprecated.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,10 @@ exports[`CommandBar renders commands correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-width: 40px;
outline: transparent;
padding-bottom: 0;
Expand Down Expand Up @@ -216,6 +220,10 @@ exports[`CommandBar renders commands correctly 1`] = `
font-size: 14px;
font-weight: 400;
height: 100%;
margin-bottom: 0px;
margin-left: 0px;
margin-right: 0px;
margin-top: 0px;
min-width: 40px;
outline: transparent;
padding-bottom: 0;
Expand Down
Loading