Scope button style overrides to fabric components#9037
Closed
hoovercj wants to merge 1 commit intomicrosoft:masterfrom
Closed
Scope button style overrides to fabric components#9037hoovercj wants to merge 1 commit intomicrosoft:masterfrom
hoovercj wants to merge 1 commit intomicrosoft:masterfrom
Conversation
Addresses microsoft#9036 __Problem:__ The margin and overflow styles are applied globally and affect non-Fabric elements. __Solution:__ The styles should be scoped to only Fabric elements.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #9036
Problem: The margin and overflow styles are applied globally and affect non-Fabric elements.
Solution: The styles should be scoped to only Fabric elements.
Pull request checklist
$ npm run changeDescription of changes
Scopes fabric button overrides to buttons wrapped in a fabric component
Focus areas to test
The bugs fixed by these PRs: #3970 and #4797
Microsoft Reviewers: Open in CodeFlow