Skip to content

ARIA: Fix mergeAriaAttributeValues not producing space delimited ID reference lists #8066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KevinTCoughlin wants to merge 2 commits into from
Closed

ARIA: Fix mergeAriaAttributeValues not producing space delimited ID reference lists #8066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b95edd4
Modify mergeAriaAttributeValues to space delimit output by default
KevinTCoughlin Feb 21, 2019
b8b8326
Add change file
KevinTCoughlin Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@uifabric/utilities/keco-fix-merge-aria-attrs_2019-02-21-18-39.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/utilities",
"comment": "Modify mergeAriaAttributeValues to return space delimited string of values",
"type": "patch"
}
],
"packageName": "@uifabric/utilities",
"email": "keco@microsoft.com"
}
4 changes: 1 addition & 3 deletions packages/utilities/src/aria.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,9 @@
* ARIA helper to concatenate attributes, returning undefined if all attributes
* are undefined. (Empty strings are not a valid ARIA attribute value.)
*
* NOTE: This function will NOT insert whitespace between provided attributes.
*
* @param ariaAttributes - ARIA attributes to merge
*/
export function mergeAriaAttributeValues(...ariaAttributes: (string | undefined)[]): string | undefined {
const mergedAttribute = ariaAttributes.filter((arg: string | undefined) => arg !== undefined && arg !== null).join('');
const mergedAttribute = ariaAttributes.filter((arg: string | undefined) => arg !== undefined && arg !== null).join(' ');

@Dalimil Dalimil Feb 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have .join(' ').trim() maybe?

return mergedAttribute === '' ? undefined : mergedAttribute;
}