Skip to content

default spellCheck=false in BasePicker #7301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joschect merged 4 commits into from
Dec 6, 2018
Merged

default spellCheck=false in BasePicker #7301

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4eed27
make spellCheck defaults to false in BasePicker
Dec 4, 2018
3a18057
rush change
Dec 4, 2018
47d2d0f
updated snapshots
Dec 5, 2018
deb4300
allowed inputProps to overwrite spellCheck
Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/huaxi-no-spellcheck-in-picker_2018-12-04-22-21.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "spellCheck defaults to false in BasePicker",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "huaxi@microsoft.com"
}
1 change: 1 addition & 0 deletions ...s/office-ui-fabric-react/src/components/__snapshots__/PeoplePicker.Types.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ exports[`Component Examples renders PeoplePicker.Types.Example.tsx correctly 1`]
onInput={[Function]}
onKeyDown={[Function]}
role="combobox"
spellCheck={false}
value=""
/>
</div>
Expand Down
2 changes: 2 additions & 0 deletions ...ages/office-ui-fabric-react/src/components/__snapshots__/TagPicker.Basic.Example.tsx.shot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ exports[`Component Examples renders TagPicker.Basic.Example.tsx correctly 1`] =
onInput={[Function]}
onKeyDown={[Function]}
role="combobox"
spellCheck={false}
value=""
/>
</div>
Expand Down Expand Up @@ -268,6 +269,7 @@ exports[`Component Examples renders TagPicker.Basic.Example.tsx correctly 1`] =
onInput={[Function]}
onKeyDown={[Function]}
role="combobox"
spellCheck={false}
value=""
/>
</div>
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/components/pickers/BasePicker.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ export class BasePicker<T, P extends IBasePickerProps<T>> extends BaseComponent<
aria-owns={suggestionsAvailable || undefined}
aria-autocomplete={'both'}
onInputChange={this.props.onInputChange}
spellCheck={false}
/>
)}
</div>
Expand Down
3 changes: 3 additions & 0 deletions ...ages/office-ui-fabric-react/src/components/pickers/__snapshots__/BasePicker.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ exports[`Pickers BasePicker renders BasePicker correctly 1`] = `
onInput={[Function]}
onKeyDown={[Function]}
role="combobox"
spellCheck={false}
value=""
/>
</div>
Expand Down Expand Up @@ -112,6 +113,7 @@ exports[`Pickers BasePicker renders BasePicker with inputProps supply classnames
onKeyDown={[Function]}
placeholder="Bitte einen Benutzer angeben..."
role="combobox"
spellCheck={false}
value=""
/>
</div>
Expand Down Expand Up @@ -171,6 +173,7 @@ exports[`Pickers TagPicker renders TagPicker correctly 1`] = `
onInput={[Function]}
onKeyDown={[Function]}
role="combobox"
spellCheck={false}
value=""
/>
</div>
Expand Down