Skip to content

Conversation

@dmichon-msft
Copy link
Contributor

@dmichon-msft dmichon-msft commented Dec 4, 2018

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ npm run change

Description of changes

Recognizes the following additional PowerShell extensions as code files:
'.psd1', '.psm1', '.ps1xml'
Recognizes the '.heic', '.heif' extensions as photos encoded with the HEIC codec (the single-frame version of HEVC)
Recognizes additional extensions for 3gp video '.3g2', '.3gp2', '.3gpp'
Recognizes the '.mak' makefile extension as a code file

Corrects an extraneous space from the '.mpa' extension

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@Jahnp
Copy link
Member

Jahnp commented Dec 4, 2018

@dmichon-msft , the change looks good, thank you! But, would you mind updating the title to be a little more descriptive for the historical record, e.g. something like "Add additional file type extensions"? Thank you!

@dmichon-msft dmichon-msft changed the title File type icons Add extensions for PowerShell, HEIC, 3gp, mak to FileTypeIconMap Dec 4, 2018
@micahgodbolt micahgodbolt merged commit 7f58d3b into microsoft:master Dec 5, 2018
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy Links:

Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request Dec 7, 2018
* master: (55 commits)
  Applying package updates.
  default spellCheck=false in BasePicker (microsoft#7301)
  Separating border:none from .cell and removing from .root to avoid style override in DetailsColumn (microsoft#7211)
  Dropdown component honors ariaLabel prop (microsoft#7292)
  Add extensions for PowerShell, HEIC, 3gp, mak to FileTypeIconMap (microsoft#7299)
  Fix microsoft#7258 - Documentation is missing for button (microsoft#7302)
  Applying package updates.
  Add customizer scope to TeachingBubbleContent (microsoft#7294)
  Applying package updates.
  DevExp: Part 2 of 2 - the codebase no longer uses const enums, enabling consumers to be able to use isolatedModules (microsoft#7119)
  Add card dgl functionality (microsoft#7287)
  Only support LTS versions of Node 8 and 10 (microsoft#7290)
  add shift into delete action (microsoft#7274)
  Update CODEOWNERS
  Adding RTL support for DetailsList drag-drop to reorder columns (microsoft#7267)
  Applying package updates.
  Improve TeachingBubble usage docs (microsoft#7266)
  Lifting the resolution of default and user provided style variables to Utilities. (microsoft#7261)
  Re-adding animation for drag-n-drop to reorder columns (microsoft#7213)
  Update DetailsList Drag & Drop Example Snapshot (microsoft#7272)
  ...
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants