-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Improve TeachingBubble usage docs #7266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Peter Jahn (Jahnp)
merged 5 commits into
microsoft:master
from
Jahnp:jahnp/teachingbubble-usagedocs
Dec 1, 2018
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e2b3188
Expand usage docs for TeachingBubble
Jahnp 2322fae
Fix image which was clipping for wide example with illustration
Jahnp 4e596eb
Merge branch 'master' of https://github.com/OfficeDev/office-ui-fabri…
Jahnp 293f84b
Add change
Jahnp 1c45fde
Update TeachingBubble overview, dos, and don'ts.
Jahnp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
11 changes: 11 additions & 0 deletions
11
common/changes/office-ui-fabric-react/jahnp-teachingbubble-usagedocs_2018-11-30-03-28.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "changes": [ | ||
| { | ||
| "packageName": "office-ui-fabric-react", | ||
| "comment": "TeachingBubble: Expand usage documentation to distinguish it from similar components.", | ||
| "type": "patch" | ||
| } | ||
| ], | ||
| "packageName": "office-ui-fabric-react", | ||
| "email": "pejahn@microsoft.com" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
...ffice-ui-fabric-react/src/components/TeachingBubble/docs/TeachingBubbleDonts.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| - Don't use TeachingBubbles for user-invoked actions. | ||
| - Don't use TeachingBubbles when a Callout would be sufficient. | ||
| - Don't show a TeachingBubble more than once, even if the user has not completed the action. | ||
|
Jahnp marked this conversation as resolved.
Outdated
Jahnp marked this conversation as resolved.
Outdated
|
||
1 change: 1 addition & 0 deletions
1
.../office-ui-fabric-react/src/components/TeachingBubble/docs/TeachingBubbleDos.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - Show one TeachingBubble at a time. |
6 changes: 5 additions & 1 deletion
6
...ce-ui-fabric-react/src/components/TeachingBubble/docs/TeachingBubbleOverview.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,5 @@ | ||
| TeachingBubbles allow the user to display important hints on their web pages with a callout box. | ||
| TeachingBubbles are a special kind of [Callout](#/components/callout) used to prominently display important hints to a specific part of a page. They should be used to educate the user about an element that may be easy to miss, such as a new feature or option in the UI. Because they increase engagement with a part of the UI, they are often paired with [Coachmarks](#/components/coachmark). | ||
|
|
||
| Because they are usually invoked by a system change rather than a user action, TeachingBubbles should generally not be used to show supplemental information or helper text. This is better suited for Callouts or [Tooltips](#/components/tooltip), which are used to simplify existing interactions. | ||
|
|
||
| TeachingBubbles should otherwise follow the same usage guidance as Callouts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.