Skip to content

Add support for Node 10 #7264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecraig12345 merged 2 commits into from
Nov 30, 2018
Merged

Add support for Node 10 #7264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea1874a
Add support for Node 10
ecraig12345 Nov 30, 2018
ba40dcd
make travis use node 10
ecraig12345 Nov 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
language: node_js
node_js:
- '8'
- '10'
script:
- node common/scripts/install-run-rush.js install --bypass-policy
- if [ $TRAVIS_BRANCH == "master" ] && [ $TRAVIS_PULL_REQUEST != "false" ];
Expand Down
2 changes: 1 addition & 1 deletion rush.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@
* Specify a SemVer range to ensure developers use a NodeJS version that is appropriate
* for your repo.
*/
"nodeSupportedVersionRange": ">=8.0.0 <10.0.0",
"nodeSupportedVersionRange": ">=8.0.0 <9.0.0 || >=10.0.0 <11.0.0",
Copy link
Contributor

@cliffkoh cliffkoh Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For node 10, maybe restrict it to more recent versions...

Copy link
Member

@dzearing dzearing Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what do you mean?

Copy link
Member

@dzearing dzearing Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or... do you know of problems with some versions?

Copy link
Member Author

@ecraig12345 ecraig12345 Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think a good start version would be? I'm not sure how to determine that.

Copy link
Contributor

@cliffkoh cliffkoh Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good version to start is the version that Node 10 first went LTS on. But I otherwise think 10.9.0 is a good starting place.

@dzearing I don't know of a specific problem, but @pgonzal really did not like to be on Node 10 initially because his perception (I believe) is that the very early versions of Node 10 are quite unstable ... and hence we generally stay at LTS.

Copy link
Member

@dzearing dzearing Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha; maybe just start at the current LTS then? (10.14.1) as we're just starting to test now.

There were a few security updates recommending minbar 10.14.0, and the .1 patch was specifcally for windows msi issues.

https://nodejs.org/en/blog/vulnerability/november-2018-security-releases/

Copy link

@octogonz octogonz Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think a good start version would be? I'm not sure how to determine that.

(1) an LTS version, and (2) something you've actually tested yourself.

It is super frustrating to waste an hour investigating somebody's issue, only to find out that it was just a buggy build of NodeJS. We got burned by this repeatedly until we finally started insisting on LTS versions.

Copy link
Member Author

@ecraig12345 ecraig12345 Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked up when 8 and 10 became LTS, and it was at 8.9.0 and 10.9.0. (Didn't know until today that each even-numbered major version is out for about 6 months before becoming officially LTS.)

@pgonzal, I'm curious what types of problems you've run into due to buggy Node builds? I don't remember encountering any issues like that myself, though I'm sure it's possible.

Copy link
Member

@KevinTCoughlin KevinTCoughlin Nov 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended DL https://groups.google.com/forum/#!forum/nodejs-sec


/**
* If you would like the version specifiers for your dependencies to be consistent, then
Expand Down