Skip to content

DetailsList: Remove drag and drop border animation causing style mutations via mergeStyles #7125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 3 commits into from
Nov 16, 2018
Merged

DetailsList: Remove drag and drop border animation causing style mutations via mergeStyles #7125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1fdf1b
Remove drag and drop animation from DetailsColumn to fix aggressive s…
KevinTCoughlin Nov 16, 2018
ac4d89c
Add changefile
KevinTCoughlin Nov 16, 2018
f2c9ee3
Fix lint error due to unused import in DetailsColumn.styles
KevinTCoughlin Nov 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/keco-fix-dl-styles-recalcs_2018-11-16-01-23.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "DetailsList: Remove drag and drop border animation causing style mutations on re-render.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "keco@microsoft.com"
}
17 changes: 3 additions & 14 deletions packages/office-ui-fabric-react/src/components/DetailsList/DetailsColumn.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { IDetailsColumnStyleProps, IDetailsColumnStyles } from './DetailsColumn.types';
import { getFocusStyle, getGlobalClassNames, hiddenContentStyle, keyframes, IStyle } from '../../Styling';
import { getFocusStyle, getGlobalClassNames, hiddenContentStyle, IStyle } from '../../Styling';
import { DEFAULT_CELL_STYLE_PROPS } from './DetailsRow.styles';
import { getCellStyles } from './DetailsHeader.styles';

Expand Down Expand Up @@ -47,15 +47,6 @@ export const getStyles = (props: IDetailsColumnStyleProps): IDetailsColumnStyles
resizerColor: palette.neutralTertiaryAlt
};

const fadeOut: string = keyframes({
from: {
borderColor: palette.themePrimary
},
to: {
borderColor: 'transparent'
}
});

const nearIconStyle: IStyle = {
color: colors.iconForegroundColor,
opacity: 1,
Expand Down Expand Up @@ -194,17 +185,15 @@ export const getStyles = (props: IDetailsColumnStyleProps): IDetailsColumnStyles
borderWidth: 1,
borderColor: palette.themePrimary,
left: -1,
lineHeight: 31,
animation: `${fadeOut} 1.5s forwards`
lineHeight: 31
}
],

borderWhileDragging: [
{
borderStyle: 'solid',
borderWidth: 1,
borderColor: palette.themePrimary,
animation: `${fadeOut} 0.2s forwards`
borderColor: palette.themePrimary
}
]
};
Expand Down