Skip to content

Conversation

@KevinTCoughlin
Copy link
Member

@KevinTCoughlin KevinTCoughlin commented Oct 4, 2018

Pull request checklist

Description of changes

This PR addresses the a11y violations for ContextualMenu examples. There is no impact to the lib, but they were flagged in #6360 so we opted to address them so folks don't copy invalid code.

Fixes:

  • Bug 1 : [Accessibility][Forms and validation]: 'Actions' label is not associated with its corresponding control.
  • Bug 2 : [Accessibility][Screen reader]: Label or place holder is not provided for the Edit field(250) present under Contextual Menu with Sub Menus
  • Bug 12 : [Accessibility][Programmatic access]: id attribute value must be unique.

ContextualMenu component a11y fixes to follow in subsequent PR.

Focus areas to test

  1. Load the ContextualMenu example pages.
  2. Verify that id attributes are unique.
  3. Verify that inputs have labels or aria-label defined.
Microsoft Reviewers: Open in CodeFlow

@natalieethell
Copy link
Contributor

Looks like snapshots just need to be updated.

@micahgodbolt micahgodbolt merged commit a6d214e into microsoft:master Oct 8, 2018
@msft-github-bot
Copy link
Contributor

🎉@uifabric/[email protected] has been released which incorporates this pull request.:tada:

Handy Links:

@msft-github-bot msft-github-bot mentioned this pull request Oct 8, 2018
18 tasks
@msft-github-bot
Copy link
Contributor

🎉[email protected] has been released which incorporates this pull request.:tada:

Handy Links:

@KevinTCoughlin KevinTCoughlin deleted the keco/ctx-menu-demo-a11y branch October 8, 2018 23:30
@KevinTCoughlin
Copy link
Member Author

Part of #6360

@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ContextualMenu A11y Pass

4 participants