Layer: Do not block capture events #6533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vitalius1
approved these changes
Oct 1, 2018
Contributor
Vitalius1
left a comment
Vitalius1
left a comment
There was a problem hiding this comment.
Approve assuming you had a repro of the issue and the fix solved it for you. Thanks for updating and adding some tests!
Contributor
|
@ThomasMichon can you get this one unblocked please! Thanks. |
Member
Author
|
Yes, I confirmed this fixes the SearchBox issue within a Panel as reported. Thanks |
Contributor
|
🎉 Handy Links: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Prevent Layer from blocking capture events. This PR allows onFocus and onBlur events to descend to Layer content as expected.
Focus areas to test
Modify unit tests to test both capture and bubble events.
Microsoft Reviewers: Open in CodeFlow