Skip to content

Fix DetailsList width given nested groups (#5857) #5968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kkjeer merged 4 commits into from
Aug 22, 2018
Merged

Fix DetailsList width given nested groups (#5857) #5968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e513e90
Fix DetailsList width given nested groups (#5857)
Aug 17, 2018
dda99ca
Add change request file for issue 5857.
Aug 17, 2018
f913cfb
Tweak change file comment.
JasonGore Aug 17, 2018
8e7b029
Rename change request file 5857 back to JSON.
Aug 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/issue5857_2018-08-17-18-09.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "DetailsList: Account for grouping depth of more than one in width calculation.",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
4 changes: 2 additions & 2 deletions packages/office-ui-fabric-react/src/components/DetailsList/DetailsList.base.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -799,10 +799,10 @@ export class DetailsListBase extends BaseComponent<IDetailsListProps, IDetailsLi
props: IDetailsListProps,
firstIndex: number
): IColumn[] {
const { selectionMode, checkboxVisibility, groups } = props;
const { selectionMode, checkboxVisibility } = props;
const rowCheckWidth =
selectionMode !== SelectionMode.none && checkboxVisibility !== CheckboxVisibility.hidden ? CHECKBOX_WIDTH : 0;
const groupExpandWidth = groups ? GROUP_EXPAND_WIDTH : 0;
const groupExpandWidth = this._getGroupNestingDepth() * GROUP_EXPAND_WIDTH;
let totalWidth = 0; // offset because we have one less inner padding.
const availableWidth = viewportWidth - (rowCheckWidth + groupExpandWidth);
const adjustedColumns: IColumn[] = newColumns.map((column, i) => {
Expand Down