Skip to content

Remove ShimmeredDetailsList from DetailsList's bundle root#5967

Merged
ThomasMichon merged 2 commits intomicrosoft:masterfrom
ThomasMichon:shimmer-bundle
Aug 17, 2018
Merged

Remove ShimmeredDetailsList from DetailsList's bundle root#5967
ThomasMichon merged 2 commits intomicrosoft:masterfrom
ThomasMichon:shimmer-bundle

Conversation

@ThomasMichon
Copy link
Copy Markdown
Member

@ThomasMichon ThomasMichon commented Aug 17, 2018

To avoid causing grief for non-shaking bundlers, this change removes ShimmeredDetailsList from DetailsList's inner-most export...again.

Microsoft Reviewers: Open in CodeFlow

@KevinTCoughlin
Copy link
Copy Markdown
Member

@ThomasMichon
Copy link
Copy Markdown
Member Author

ThomasMichon commented Aug 17, 2018

Seriously, SizeAuditor doesn't like it when the the bundle gets too small!?

@ThomasMichon ThomasMichon merged commit 5fcee6b into microsoft:master Aug 17, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants