Skip to content

Part 3 of 3: DetailsList CSS-in-JS conversion #5514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenotron merged 12 commits into from
Jul 12, 2018
Merged

Part 3 of 3: DetailsList CSS-in-JS conversion #5514

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8a44e62
detailslist WIP
kenotron Jul 10, 2018
cd2c7a2
Merge branch 'master' into detailslist
kenotron Jul 11, 2018
b3cc2fb
Remaining conversion of DetailsList
kenotron Jul 11, 2018
bee70e1
change file
kenotron Jul 11, 2018
f2530fc
added a few more snapshot tests and updated snapshots
kenotron Jul 11, 2018
75ee48c
updating scopes for the styled components
kenotron Jul 11, 2018
b0bb6fd
Converts shimmered details list as well
kenotron Jul 11, 2018
23a6044
enables other examples
kenotron Jul 11, 2018
15fae0a
adding some jsdoc for the shimmereddetailslisttypes
kenotron Jul 11, 2018
fe46896
fixed an unused var
kenotron Jul 11, 2018
0e7199b
Updated based on feedback
kenotron Jul 12, 2018
0ab606c
get rid of unused type
kenotron Jul 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/detailslist_2018-07-11-05-34.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Remaining CSS-in-JS conversion of DetailsList",
Copy link
Contributor

@cliffkoh cliffkoh Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DetailsList: Complete CSS-in-JS conversion.

Copy link
Contributor Author

@kenotron kenotron Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
4 changes: 3 additions & 1 deletion packages/office-ui-fabric-react/src/components/Check/Check.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,6 @@ import { ICheckProps, ICheckStyleProps, ICheckStyles } from './Check.types';
import { CheckBase } from './Check.base';
import { getStyles } from './Check.styles';

export const Check = styled<ICheckProps, ICheckStyleProps, ICheckStyles>(CheckBase, getStyles);
export const Check = styled<ICheckProps, ICheckStyleProps, ICheckStyles>(CheckBase, getStyles, undefined, {
scope: 'Check'
});
4 changes: 3 additions & 1 deletion packages/office-ui-fabric-react/src/components/DetailsList/DetailsHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@ export { IDetailsHeaderProps };

export const DetailsHeader = styled<IDetailsHeaderProps, IDetailsHeaderStyleProps, IDetailsHeaderStyles>(
DetailsHeaderBase,
getStyles
getStyles,
Copy link
Contributor

@cliffkoh cliffkoh Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename to DetailsHeader.ts (same thing for the other files like this)

Copy link
Contributor Author

@kenotron kenotron Jul 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done renaming

undefined,
{ scope: 'DetailsHeader' }
);
Loading