Details List - Column Drag drop changes#5502
Merged
ThomasMichon merged 25 commits intomicrosoft:5.0from Jul 11, 2018
Merged
Conversation
ThomasMichon
approved these changes
Jul 10, 2018
cliffkoh
approved these changes
Jul 10, 2018
Contributor
|
Please feel free to merge. You can ignore the Appveyor failure. |
kenotron
previously requested changes
Jul 10, 2018
Contributor
kenotron
left a comment
kenotron
left a comment
There was a problem hiding this comment.
Can you please wait until my change is thru before merging this? I've had to redo the styling of DL Header to CSS-in-JS. This will affect styles I had to port by hand a bit it seems (I'm hitting "request changes" until I get mine in)
kenotron
reviewed
Jul 10, 2018
Contributor
kenotron
left a comment
kenotron
left a comment
There was a problem hiding this comment.
Just realized this is targeting 5.0, rescinding my block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Porting 3 PRs from version 6 to support column drag and drop in Details List
List of PRs:
#4857
#5309
#5432
Microsoft Reviewers: Open in CodeFlow