Skip to content

DragDropHelper: Add support for optional onDragOver prop in IDragDropOptions #5380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cliffkoh merged 3 commits into from
Jul 3, 2018
Merged

DragDropHelper: Add support for optional onDragOver prop in IDragDropOptions #5380

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0df28e
Add onDragOver to props in DragDropHelper
Jun 28, 2018
d5efe80
Add change file
Jun 28, 2018
d896a1b
Update change type to minor
Jun 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/erichdev-onDragOverHelper_2018-06-28-23-26.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "DragDropHelper: Add support for `onDragOver` prop in IDragDropOptions",
"type": "patch"

@cliffkoh cliffkoh Jun 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be minor?

}
],
"packageName": "office-ui-fabric-react",
"email": "erabelle@microsoft.com"
}
4 changes: 4 additions & 0 deletions packages/office-ui-fabric-react/src/utilities/dragdrop/DragDropHelper.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,10 @@ export class DragDropHelper implements IDragDropHelper {

onDragOver = (event: DragEvent) => {
event.preventDefault();

if (dragDropOptions.onDragOver) {
dragDropOptions.onDragOver(dragDropOptions.context.data, event);
}
};

this._dragEnterCounts[key] = 0;
Expand Down
1 change: 1 addition & 0 deletions packages/office-ui-fabric-react/src/utilities/dragdrop/interfaces.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ export interface IDragDropOptions {
onDragStart?: (item?: any, itemIndex?: number, selectedItems?: any[], event?: MouseEvent) => void;
onDrop?: (item?: any, event?: DragEvent) => void;
onDragEnd?: (item?: any, event?: DragEvent) => void;
onDragOver?: (item?: any, event?: DragEvent) => void;
}

export interface IDragDropEvent {
Expand Down