ChoiceGroup: getStyles conversion#4964
Merged
JasonGore merged 20 commits intomicrosoft:new_6.0from May 23, 2018
Merged
Conversation
… split out ChoiceGroupOption into subcomponent. Everything working except Focus rect right now
…c-react into ChoiceGroup # Conflicts: # packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.tsx # packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.types.ts
FalseLobster
approved these changes
May 23, 2018
Member
|
woot woot |
|
#3872 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Splits ChoiceGroup into two components, ChoiceGroup and ChoiceGroupOption
Migrates from scss styling to javascript-based getStyles
Adds support for conditionally applying global class names
Props mutation has been resolved by this PR, but consumers expecting this mutation may see this as a breaking change. Therefore this PR is a retargeting of #4852 to 6.0.
Focus areas to test
ChoiceGroup visuals
Microsoft Reviewers: Open in CodeFlow