Skip to content

Revert ChoiceGroup change in 5.0 to minimize potential partner impact. #4962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dzearing merged 2 commits into from
May 23, 2018
Merged

Revert ChoiceGroup change in 5.0 to minimize potential partner impact. #4962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91614e2
Revert "ChoiceGroup: getStyles conversion (#4852)"
dzearing May 23, 2018
8c6f82d
Adding change files.
dzearing May 23, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/@uifabric/utilities/revert-choicegroup_2018-05-23-14-52.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/utilities",
"comment": "Reverting the ChoiceGroup styling update along with updates to utilities to avoid potentially breaking changes.",
"type": "minor"
}
],
"packageName": "@uifabric/utilities",
"email": "dzearing@microsoft.com"
}
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/revert-choicegroup_2018-05-23-14-52.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "ChoiceGroup: Reverting the updates to ChoiceGroup styling. We found some breaking changes in it, so we'd like to minimize partner impact by moving this to the 6.0 (next) release. Sorry for the trouble.",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "dzearing@microsoft.com"
}
185 changes: 0 additions & 185 deletions packages/office-ui-fabric-react/src/components/ChoiceGroup/ChoiceGroup.base.tsx
View file
Open in desktop

This file was deleted.

Loading