Skip to content

Revisited the Multi-select Combo box initial state selection fix #4884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
natalieethell merged 1 commit into from
May 24, 2018
Merged

Revisited the Multi-select Combo box initial state selection fix #4884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/ap-dev_2018-05-16-09-35.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Revisited the Multi-select Combo box initial state selection fix",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "asish2k14@outlook.com"
}
3 changes: 2 additions & 1 deletion packages/office-ui-fabric-react/src/components/ComboBox/ComboBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,7 +804,8 @@ export class ComboBox extends BaseComponent<IComboBoxProps, IComboBoxState> {
return;
}
if (this.props.multiSelect) {
option.selected = !option.selected;
// Setting the initial state of option.selected in Multi-select combobox by checking the selectedIndices array and overriding the undefined issue
option.selected = option.selected !== undefined ? !option.selected : (selectedIndices.indexOf(index) < 0);
if (option.selected && selectedIndices.indexOf(index) < 0) {
selectedIndices.push(index);
} else if (!option.selected && selectedIndices.indexOf(index) >= 0) {
Expand Down