Issue#4832: Break ContextualMenu Types hard dependency from class ContextualMenu #4842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschect
reviewed
May 10, 2018
| } | ||
|
|
||
| export interface IContextualMenuProps extends React.Props<ContextualMenu>, IWithResponsiveModeState { | ||
| export interface IContextualMenuProps extends React.Props<any>, IWithResponsiveModeState { |
Contributor
There was a problem hiding this comment.
Definitely shouldn't be any. Make it an empty {} if it shouldn't correspond to anything.
Alternatively you could probably remove React.Props. It's really not supposed to extend that any more. It should certainly be removed in 6.0
Contributor
Author
There was a problem hiding this comment.
That was the first attempt but it causes compile error. While true we should get rid of it, I am not sure what is story for being backward compatible
Contributor
Author
|
abandoning this pull request to #4845 to fix rush change problem |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Description of changes
In an effort to reduce bundle size on critical path rendering, we are trying to defer what is not required upfront. One such control from Fabric for us is ContextualMenu, which is required for edit scenario mostly. However What we learned is we cannot chunk this from core because we need BaseButton and It has hard dependency on IContextualMenuProps. Which is fine.
Unfortunately IContextualMenuProps have hard dependency on ContextualMenu which is not fine.
export interface IContextualMenuProps extends React.Props, IWithResponsiveModeState {
Focus areas to test
This is not supposed to change any runtime behavior as change is in typing only