Skip to content

Website: Scroll to top of page on navigation #4810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lynamemi merged 3 commits into from
May 8, 2018
Merged

Website: Scroll to top of page on navigation #4810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1989c2d
Scroll to top of page on navigation
lynamemi May 8, 2018
a396029
Added change file
lynamemi May 8, 2018
da857a0
Props types
lynamemi May 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/fabric-website/src/components/App/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ export class App extends React.Component<IAppProps, any> {
window.removeEventListener('resize', this._handleNavPositioning);
}

public componentWillReceiveProps(nextProps: IAppProps): void {
if (nextProps && nextProps.children !== this.props.children) {
document.body.scrollTop = document.documentElement.scrollTop = 0;
}
}

public render(): JSX.Element {
let { navHeight } = this.state;
let navPosition: 'fixed' | 'absolute' = this.state.isAttached ? 'fixed' : 'absolute';
Expand Down
11 changes: 11 additions & 0 deletions common/changes/@uifabric/fabric-website/new-page-scroll_2018-05-08-15-14.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "@uifabric/fabric-website",
"comment": "When navigating to a new page, the page will now be scrolled to the top instead of whatever position of the page you were on.",
"type": "patch"
}
],
"packageName": "@uifabric/fabric-website",
"email": "[email protected]"
}