Skip to content

Popup: Added check for onBlur to prevent focus setting focus to be incorrectly disabled when closing a menu in Chrome #4804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chang47 merged 3 commits into from
May 8, 2018
Merged

Popup: Added check for onBlur to prevent focus setting focus to be incorrectly disabled when closing a menu in Chrome #4804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98164b7
added check in blur to prevent focus from being set accidentally
May 7, 2018
06d018d
added change file
May 7, 2018
c7bb2b6
resolve merge
May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions ...n/changes/office-ui-fabric-react/chiechan-allowFocusToReturnInPopup_2018-05-07-22-58.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Popup: Added check for onBlur to prevent focus setting focus to be disabled in chrome",
"type": "patch"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
6 changes: 4 additions & 2 deletions packages/office-ui-fabric-react/src/components/Popup/Popup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,9 @@ export class Popup extends BaseComponent<IPopupProps, IPopupState> {
this._containsFocus = true;
}

private _onBlur(): void {
this._containsFocus = false;
private _onBlur(ev: React.FocusEvent<HTMLElement>): void {
if (this._root.value && this._root.value.contains(ev.relatedTarget as HTMLElement)) {
this._containsFocus = false;
}
}
}