Skip to content

#218302: updated keyboard focus styles for pivot links and pivot tab … #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dubunin merged 2 commits into from
Aug 3, 2016
+22 −13
Merged

#218302: updated keyboard focus styles for pivot links and pivot tab … #48

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b73316
#218302: updated keyboard focus styles for pivot links and pivot tab …
Aug 2, 2016
7069ee9
#218302: localized margin-right
Aug 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions src/components/Pivot/Pivot.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@
@include ms-u-normalize;
font-size: $ms-font-size-m;
font-weight: $ms-font-weight-regular;
position: relative;
color: $ms-color-themePrimary;
white-space: nowrap;
}

.ms-Pivot-links {
Expand All @@ -37,6 +40,10 @@
cursor: pointer;
}

&:focus {
outline: none;
}

// Underline, not yet visible
&::before {
background-color: transparent;
Expand Down Expand Up @@ -77,12 +84,14 @@
}
}



.ms-Fabric.is-focusVisible .ms-Pivot-link {
&:focus {
outline: 1px solid $ms-color-neutralSecondaryAlt;

@Jahnp Jahnp Aug 2, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just checking--does this clash at all with the implementation below for the tabs component?

@dubunin dubunin Aug 2, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. When you use the focus-border mixin for the tabs it cancels this out.

@Jahnp Jahnp Aug 2, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha--thanks!

}
}

// @TODO: Determine if any of the styles below this are necessary anymore.


// Overflow (ellipsis)
.ms-Pivot-link.ms-Pivot-link--overflow {
color: $ms-color-neutralSecondary;
Expand Down Expand Up @@ -133,16 +142,16 @@
}
}


//== Modifier: Tabs
//
.ms-Pivot.ms-Pivot--tabs {

.ms-Pivot-link {
@include focus-border();
height: 40px;
background-color: $ms-color-neutralLighter;
line-height: 40px;
margin-right: -2px; // Remove space next to inline-block element
margin-right: 0px; // Remove space next to inline-block element

@Jahnp Jahnp Aug 2, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be localized

@dubunin dubunin Aug 2, 2016

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

padding: 0 10px;

&:hover:not(.is-selected):not(.ms-Pivot-link--overflow),
Expand Down Expand Up @@ -175,6 +184,14 @@
}
}

.ms-Fabric.is-focusVisible .ms-Pivot.ms-Pivot--tabs .ms-Pivot-link:focus {
&:before {
height: auto;
background: transparent;
transition: none;
}
}

// @TODO: Confirm that this component is not responsive.
//
// @media (min-width: $ms-screen-lg-min) {
Expand All @@ -199,11 +216,3 @@
}
}
}

// TODO: Remove override below.

.ms-Pivot {
position: relative;
color: $ms-color-themePrimary;
white-space: nowrap;
}