Skip to content

Mark Slider#ValuePosition enum as deprecated as it is unused. #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KevinTCoughlin merged 2 commits into from
May 8, 2018
Merged

Mark Slider#ValuePosition enum as deprecated as it is unused. #4799

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87a4a1b
Mark ValuePosition enum as deprecated as it is unused.
KevinTCoughlin May 7, 2018
a180025
+ changefile
KevinTCoughlin May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions common/changes/office-ui-fabric-react/keco-deprec-unused-slider-enum_2018-05-07-20-05.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
{
"changes": [
{
"packageName": "office-ui-fabric-react",
"comment": "Mark Slider's ValuePosition enum as deprecated as it is unused.",
"type": "minor"
}
],
"packageName": "office-ui-fabric-react",
"email": "[email protected]"
}
3 changes: 3 additions & 0 deletions packages/office-ui-fabric-react/src/components/Slider/Slider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ export interface ISliderState {
renderedValue?: number;
}

/**
Copy link
Collaborator

@oengusmacinog-zz oengusmacinog-zz May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micahgodbolt you were the last person to touch this code. Do you know of any reason not to remove this in v6?

Copy link
Member

@micahgodbolt micahgodbolt May 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yank away

* @deprecated Unused. Do not use, will be removed in 6.0
*/
export enum ValuePosition {
Previous = 0,
Next = 1
Expand Down