Fix breadcrumb rendering issue when overflow item is at last index #4787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
resetting the build to see if something hiccup'd with screener. |
dzearing
reviewed
May 7, 2018
| <li className={ this._classNames.listItem } key={ item.key || String(index) }> | ||
| { onRenderItem(item, this._onRenderItem) } | ||
| { index !== lastItemIndex && ( | ||
| { (index !== lastItemIndex || (hasOverflowItems && index === overflowIndex! - 1)) && ( |
Member
There was a problem hiding this comment.
mind adding some parenthesis to ensure your booleans are evaluating what to expect?
&& index === (overflowIndex - 1)
Also you shouldn't need to add a ! after overflowIndex; should it default to a value? Or should you check for undefined?
Collaborator
Author
There was a problem hiding this comment.
We have the overflowIndex as default props but the default props is not working with optional props. Compiler complains Object is possibly 'undefined'
JasonGore
approved these changes
May 7, 2018
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
May 13, 2018
* master: (52 commits) Marqueeselection style update (microsoft#4803) Applying package updates. FocusZone: Add the ability to stop focus from propagating outside the FocusZone (microsoft#4823) Unknown persona coin (microsoft#4809) Applying package updates. BaseButton: Allow Alt + Down on menu buttons to open the menu (microsoft#4807) Applying package updates. Website: Scroll to top of page on navigation (microsoft#4810) Applying package updates. ActivityItem: fix getstyles (microsoft#4802) Mark Slider#ValuePosition enum as deprecated as it is unused. (microsoft#4799) Icon: ensure `styles` still works. (microsoft#4805) Popup: Added check for onBlur to prevent focus setting focus to be incorrectly disabled when closing a menu in Chrome (microsoft#4804) Update package.json Move <Layer> to use React portals when available (microsoft#4724) Fix breadcrumb rendering issue when overflow item is at last index (microsoft#4787) Fixes focus issue for contextual menus (microsoft#4744) Remove redundant selected items prop on BaseExtendedPicker (microsoft#4769) SearchBox: New prop for turning off icon animation (microsoft#4794) Add functions to ContextualMenuItem to open and close menus on command (microsoft#4741) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
The Breadcrumb component renders the divider to the last item when overflow index is set to the last item. Also the divider is not rendered next to the normal item for the case A > ...
In the first scenario, we don't check last index when rendering overflow item
In second scenario, we need to allow to render divider if there is a overflow item.
This change checks for those values and renders it correctly
to
@dzearing Could you take a look